Commit 6287dee8 authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

media: s5k6a3: add missing clk_disable_unprepare 



Fix smatch warning:

drivers/media/i2c/s5k6a3.c:234 __s5k6a3_power_on() warn: 'sensor->clock' from clk_prepare_enable() not released on lines: 234.

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent eca89cf6

drivers/media/i2c/s5k6a3.c

+3 −1
Original line number Diff line number Diff line
@@ -213,7 +213,7 @@ static int __s5k6a3_power_on(struct s5k6a3 *sensor) 
	for (i++; i < S5K6A3_NUM_SUPPLIES; i++) {

		ret = regulator_enable(sensor->supplies[i].consumer);

		if (ret < 0)

			goto error_reg_dis;

			goto error_clk;

	}



	gpio_set_value(sensor->gpio_reset, 1);
@@ -226,6 +226,8 @@ static int __s5k6a3_power_on(struct s5k6a3 *sensor) 
	msleep(20);

	return 0;



error_clk:

	clk_disable_unprepare(sensor->clock);

error_reg_dis:

	for (--i; i >= 0; --i)

		regulator_disable(sensor->supplies[i].consumer);