Commit 62866c23 authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab
Browse files

media: atomisp: Make atomisp_init_sensor() check if the sensor supports binning 

Make atomisp_init_sensor() check if the sensor supports binning.

This is a preparation patch for using the selection / crop support
to determine the padding values to use with a specific sensor.

Link: https://lore.kernel.org/r/20230529103741.11904-18-hdegoede@redhat.com



Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent a08183b8

drivers/staging/media/atomisp/pci/atomisp_internal.h

+1 −0
Original line number Diff line number Diff line
@@ -126,6 +126,7 @@ struct atomisp_input_subdev { 
	unsigned int type;

	enum atomisp_camera_port port;

	u32 code; /* MEDIA_BUS_FMT_* */

	bool binning_support;

	bool crop_support;

	struct v4l2_subdev *camera;

	/* Sensor rects for sensors which support crop */

drivers/staging/media/atomisp/pci/atomisp_v4l2.c

+27 −3
Original line number Diff line number Diff line
@@ -934,11 +934,12 @@ static int atomisp_register_entities(struct atomisp_device *isp) 
static void atomisp_init_sensor(struct atomisp_input_subdev *input)

{

	struct v4l2_subdev_mbus_code_enum mbus_code_enum = { };

	struct v4l2_subdev_frame_size_enum fse = { };

	struct v4l2_subdev_state sd_state = {

		.pads = &input->pad_cfg,

	};

	struct v4l2_subdev_selection sel = { };

	int err;

	int i, err;



	mbus_code_enum.which = V4L2_SUBDEV_FORMAT_ACTIVE;

	err = v4l2_subdev_call(input->camera, pad, enum_mbus_code, NULL, &mbus_code_enum);
@@ -961,6 +962,28 @@ static void atomisp_init_sensor(struct atomisp_input_subdev *input) 


	input->active_rect = sel.r;



	/*

	 * Check for a framesize with half active_rect width and height,

	 * if found assume the sensor supports binning.

	 * Do this before changing the crop-rect since that may influence

	 * enum_frame_size results.

	 */

	for (i = 0; ; i++) {

		fse.index = i;

		fse.code = input->code;

		fse.which = V4L2_SUBDEV_FORMAT_ACTIVE;



		err = v4l2_subdev_call(input->camera, pad, enum_frame_size, NULL, &fse);

		if (err)

			break;



		if (fse.min_width <= (input->active_rect.width / 2) &&

		    fse.min_height <= (input->active_rect.height / 2)) {

			input->binning_support = true;

			break;

		}

	}



	/*

	 * The ISP also wants the non-active pixels at the border of the sensor

	 * for padding, set the crop rect to cover the entire sensor instead
@@ -983,9 +1006,10 @@ static void atomisp_init_sensor(struct atomisp_input_subdev *input) 
	if (err)

		return;



	dev_info(input->camera->dev, "Supports crop native %dx%d active %dx%d\n",

	dev_info(input->camera->dev, "Supports crop native %dx%d active %dx%d binning %d\n",

		 input->native_rect.width, input->native_rect.height,

		 input->active_rect.width, input->active_rect.height);

		 input->active_rect.width, input->active_rect.height,

		 input->binning_support);



	input->crop_support = true;

}