Commit 625a1cae authored May 01, 2018 by Quinn Tran Committed by Martin K. Petersen May 08, 2018

scsi: qla2xxx: Fix sending ADISC command for login



This patch fixes login_retry login for ADISC command.

when login_retry count reaches 0, further attempt to send ADISC command
is ignored by the code. Remove this redundant login_retry count check
from qla24xx_fcport_handle_login()

[mkp: fix typo]

Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent f6972d71

drivers/scsi/qla2xxx/qla_init.c

+2 −4

Original line number	Original line	Diff line number	Diff line
	@@ -1167,9 +1167,6 @@ int qla24xx_fcport_handle_login(struct scsi_qla_host vha, fc_port_t fcport)
	fcport->login_gen, fcport->login_retry,		fcport->login_gen, fcport->login_retry,
	fcport->loop_id, fcport->scan_state);		fcport->loop_id, fcport->scan_state);

	if (fcport->login_retry == 0)
	return 0;

	if (fcport->scan_state != QLA_FCPORT_FOUND)		if (fcport->scan_state != QLA_FCPORT_FOUND)
	return 0;		return 0;

	@@ -1194,6 +1191,7 @@ int qla24xx_fcport_handle_login(struct scsi_qla_host vha, fc_port_t fcport)
	return 0;		return 0;
	}		}

			if (fcport->login_retry > 0)
	fcport->login_retry--;		fcport->login_retry--;

	switch (fcport->disc_state) {		switch (fcport->disc_state) {