Commit 62008578 authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: Fix printk field formatting 

Previously we used "%#08x" to print a 32-bit value.  This fills an
8-character field with "0x...", but of course many 32-bit values require a
10-character field "0x12345678" for this format.  Fix the formats to avoid
confusion.

Link: https://lore.kernel.org/r/20230824193712.542167-5-helgaas@kernel.org


Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent a49287d3

drivers/pci/setup-res.c

+2 −2
Original line number Diff line number Diff line
@@ -104,7 +104,7 @@ static void pci_std_update_resource(struct pci_dev *dev, int resno) 
	pci_read_config_dword(dev, reg, &check);



	if ((new ^ check) & mask) {

		pci_err(dev, "BAR %d: error updating (%#08x != %#08x)\n",

		pci_err(dev, "BAR %d: error updating (%#010x != %#010x)\n",

			resno, new, check);

	}
@@ -113,7 +113,7 @@ static void pci_std_update_resource(struct pci_dev *dev, int resno) 
		pci_write_config_dword(dev, reg + 4, new);

		pci_read_config_dword(dev, reg + 4, &check);

		if (check != new) {

			pci_err(dev, "BAR %d: error updating (high %#08x != %#08x)\n",

			pci_err(dev, "BAR %d: error updating (high %#010x != %#010x)\n",

				resno, new, check);

		}

	}