Commit 61f37154 authored by Christoph Hellwig's avatar Christoph Hellwig
Browse files

nvmet: use NVME_CMD_EFFECTS_CSUPP instead of open coding it 



Use NVME_CMD_EFFECTS_CSUPP instead of open coding it and assign a
single value to multiple array entries instead of repeated assignments.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarKeith Busch <kbusch@kernel.org>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarKanchan Joshi <joshi.k@samsung.com>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
parent 685e6311

drivers/nvme/target/admin-cmd.c

+19 −16
Original line number Diff line number Diff line
@@ -164,26 +164,29 @@ static void nvmet_execute_get_log_page_smart(struct nvmet_req *req) 


static void nvmet_get_cmd_effects_nvm(struct nvme_effects_log *log)

{

	log->acs[nvme_admin_get_log_page]	= cpu_to_le32(1 << 0);

	log->acs[nvme_admin_identify]		= cpu_to_le32(1 << 0);

	log->acs[nvme_admin_abort_cmd]		= cpu_to_le32(1 << 0);

	log->acs[nvme_admin_set_features]	= cpu_to_le32(1 << 0);

	log->acs[nvme_admin_get_features]	= cpu_to_le32(1 << 0);

	log->acs[nvme_admin_async_event]	= cpu_to_le32(1 << 0);

	log->acs[nvme_admin_keep_alive]		= cpu_to_le32(1 << 0);



	log->iocs[nvme_cmd_read]		= cpu_to_le32(1 << 0);

	log->iocs[nvme_cmd_write]		= cpu_to_le32(1 << 0);

	log->iocs[nvme_cmd_flush]		= cpu_to_le32(1 << 0);

	log->iocs[nvme_cmd_dsm]			= cpu_to_le32(1 << 0);

	log->iocs[nvme_cmd_write_zeroes]	= cpu_to_le32(1 << 0);

	log->acs[nvme_admin_get_log_page] =

	log->acs[nvme_admin_identify] =

	log->acs[nvme_admin_abort_cmd] =

	log->acs[nvme_admin_set_features] =

	log->acs[nvme_admin_get_features] =

	log->acs[nvme_admin_async_event] =

	log->acs[nvme_admin_keep_alive] =

		cpu_to_le32(NVME_CMD_EFFECTS_CSUPP);



	log->iocs[nvme_cmd_read] =

	log->iocs[nvme_cmd_write] =

	log->iocs[nvme_cmd_flush] =

	log->iocs[nvme_cmd_dsm]	=

	log->iocs[nvme_cmd_write_zeroes] =

		cpu_to_le32(NVME_CMD_EFFECTS_CSUPP);

}



static void nvmet_get_cmd_effects_zns(struct nvme_effects_log *log)

{

	log->iocs[nvme_cmd_zone_append]		= cpu_to_le32(1 << 0);

	log->iocs[nvme_cmd_zone_mgmt_send]	= cpu_to_le32(1 << 0);

	log->iocs[nvme_cmd_zone_mgmt_recv]	= cpu_to_le32(1 << 0);

	log->iocs[nvme_cmd_zone_append] =

	log->iocs[nvme_cmd_zone_mgmt_send] =

	log->iocs[nvme_cmd_zone_mgmt_recv] =

		cpu_to_le32(NVME_CMD_EFFECTS_CSUPP);

}



static void nvmet_execute_get_log_cmd_effects_ns(struct nvmet_req *req)