Commit 61ba93b4 authored by Ding Xiang's avatar Ding Xiang Committed by Takashi Iwai
Browse files

selftests: ALSA: remove unused variables 



These variables are never referenced in the code, just remove them.

Signed-off-by: default avatarDing Xiang <dingxiang@cmss.chinamobile.com>
Reviewed-by: default avatarMark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20230908081040.197243-1-dingxiang@cmss.chinamobile.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 0bb80ecc

tools/testing/selftests/alsa/conf.c

+0 −1
Original line number Diff line number Diff line
@@ -431,7 +431,6 @@ long conf_get_long(snd_config_t *root, const char *key1, const char *key2, long 
int conf_get_bool(snd_config_t *root, const char *key1, const char *key2, int def)

{

	snd_config_t *cfg;

	long l;

	int ret;



	if (!root)

tools/testing/selftests/alsa/mixer-test.c

+3 −8
Original line number Diff line number Diff line
@@ -188,7 +188,7 @@ static int wait_for_event(struct ctl_data *ctl, int timeout) 
{

	unsigned short revents;

	snd_ctl_event_t *event;

	int count, err;

	int err;

	unsigned int mask = 0;

	unsigned int ev_id;
@@ -430,7 +430,6 @@ static bool strend(const char *haystack, const char *needle) 
static void test_ctl_name(struct ctl_data *ctl)

{

	bool name_ok = true;

	bool check;



	ksft_print_msg("%d.%d %s\n", ctl->card->card, ctl->elem,

		       ctl->name);
@@ -863,7 +862,6 @@ static bool test_ctl_write_invalid_value(struct ctl_data *ctl, 
					 snd_ctl_elem_value_t *val)

{

	int err;

	long val_read;



	/* Ideally this will fail... */

	err = snd_ctl_elem_write(ctl->card->handle, val);
@@ -883,8 +881,7 @@ static bool test_ctl_write_invalid_value(struct ctl_data *ctl, 


static bool test_ctl_write_invalid_boolean(struct ctl_data *ctl)

{

	int err, i;

	long val_read;

	int i;

	bool fail = false;

	snd_ctl_elem_value_t *val;

	snd_ctl_elem_value_alloca(&val);
@@ -994,8 +991,7 @@ static bool test_ctl_write_invalid_integer64(struct ctl_data *ctl) 


static bool test_ctl_write_invalid_enumerated(struct ctl_data *ctl)

{

	int err, i;

	unsigned int val_read;

	int i;

	bool fail = false;

	snd_ctl_elem_value_t *val;

	snd_ctl_elem_value_alloca(&val);
@@ -1027,7 +1023,6 @@ static bool test_ctl_write_invalid_enumerated(struct ctl_data *ctl) 
static void test_ctl_write_invalid(struct ctl_data *ctl)

{

	bool pass;

	int err;



	/* If the control is turned off let's be polite */

	if (snd_ctl_elem_info_is_inactive(ctl->info)) {

tools/testing/selftests/alsa/pcm-test.c

+2 −2
Original line number Diff line number Diff line
@@ -257,7 +257,7 @@ static void find_pcms(void) 
static void test_pcm_time(struct pcm_data *data, enum test_class class,

			  const char *test_name, snd_config_t *pcm_cfg)

{

	char name[64], key[128], msg[256];

	char name[64], msg[256];

	const int duration_s = 2, margin_ms = 100;

	const int duration_ms = duration_s * 1000;

	const char *cs;
@@ -567,7 +567,7 @@ int main(void) 
{

	struct card_data *card;

	struct pcm_data *pcm;

	snd_config_t *global_config, *cfg, *pcm_cfg;

	snd_config_t *global_config, *cfg;

	int num_pcm_tests = 0, num_tests, num_std_pcm_tests;

	int ret;

	void *thread_ret;

tools/testing/selftests/alsa/test-pcmtest-driver.c

+0 −1
Original line number Diff line number Diff line
@@ -313,7 +313,6 @@ TEST_F(pcmtest, ni_playback) { 
 */

TEST_F(pcmtest, reset_ioctl) {

	snd_pcm_t *handle;

	unsigned char *it;

	int test_res;

	struct pcmtest_test_params *params = &self->params;