Commit 619e9e14 authored by Jason Wang's avatar Jason Wang Committed by Michael S. Tsirkin
Browse files

virtio: use WARN_ON() to warning illegal status value 



We used to use BUG_ON() in virtio_device_ready() to detect illegal
status value, this seems sub-optimal since the value is under the
control of the device. Switch to use WARN_ON() instead.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Halil Pasic <pasic@linux.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Cc: Vineeth Vijayan <vneethv@linux.ibm.com>
Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
Cc: linux-s390@vger.kernel.org
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
Message-Id: <20220527060120.20964-10-jasowang@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reviewed-by: default avatarXuan Zhuo <xuanzhuo@linux.alibaba.com>
parent 8b4ec69d

include/linux/virtio_config.h

+1 −1
Original line number Diff line number Diff line
@@ -255,7 +255,7 @@ void virtio_device_ready(struct virtio_device *dev) 
{

	unsigned status = dev->config->get_status(dev);



	BUG_ON(status & VIRTIO_CONFIG_S_DRIVER_OK);

	WARN_ON(status & VIRTIO_CONFIG_S_DRIVER_OK);



	/*

	 * The virtio_synchronize_cbs() makes sure vring_interrupt()