Commit 617f55e2 authored Feb 16, 2022 by Kees Cook

lib: overflow: Convert to Kunit



Convert overflow unit tests to KUnit, for better integration into the
kernel self test framework. Includes a rename of test_overflow.c to
overflow_kunit.c, and CONFIG_TEST_OVERFLOW to CONFIG_OVERFLOW_KUNIT_TEST.

$ ./tools/testing/kunit/kunit.py run overflow
...
[14:33:51] Starting KUnit Kernel (1/1)...
[14:33:51] ============================================================
[14:33:51] ================== overflow (11 subtests) ==================
[14:33:51] [PASSED] u8_overflow_test
[14:33:51] [PASSED] s8_overflow_test
[14:33:51] [PASSED] u16_overflow_test
[14:33:51] [PASSED] s16_overflow_test
[14:33:51] [PASSED] u32_overflow_test
[14:33:51] [PASSED] s32_overflow_test
[14:33:51] [PASSED] u64_overflow_test
[14:33:51] [PASSED] s64_overflow_test
[14:33:51] [PASSED] overflow_shift_test
[14:33:51] [PASSED] overflow_allocation_test
[14:33:51] [PASSED] overflow_size_helpers_test
[14:33:51] ==================== [PASSED] overflow =====================
[14:33:51] ============================================================
[14:33:51] Testing complete. Passed: 11, Failed: 0, Crashed: 0, Skipped: 0, Errors: 0
[14:33:51] Elapsed time: 12.525s total, 0.001s configuring, 12.402s building, 0.101s running

Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Co-developed-by: Vitor Massaru Iha <vitor@massaru.org>
Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
Link: https://lore.kernel.org/lkml/20200720224418.200495-1-vitor@massaru.org/


Co-developed-by: Daniel Latypov <dlatypov@google.com>
Signed-off-by: Daniel Latypov <dlatypov@google.com>
Link: https://lore.kernel.org/linux-kselftest/20210503211536.1384578-1-dlatypov@google.com/


Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Link: https://lore.kernel.org/lkml/CAKwvOdm62iA1dNiC6Q11UJ-MnTqtc4kXkm-ubPaFMK824_k0nw@mail.gmail.com


Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: David Gow <davidgow@google.com>
Link: https://lore.kernel.org/lkml/CABVgOS=TWVh649_Vjo3wnMu9gZnq66gkV-LtGgsksAWMqc+MSA@mail.gmail.com

parent 230f6fa2

lib/Kconfig.debug

+13 −3

Original line number	Diff line number	Diff line
		@@ -2214,9 +2214,6 @@ config TEST_UUID
		config TEST_XARRAY
		tristate "Test the XArray code at runtime"

		config TEST_OVERFLOW
		tristate "Test check_*_overflow() functions at runtime"

		config TEST_RHASHTABLE
		tristate "Perform selftest on resizable hash table"
		help
		@@ -2501,6 +2498,19 @@ config MEMCPY_KUNIT_TEST

		If unsure, say N.

		config OVERFLOW_KUNIT_TEST
		tristate "Test check_*_overflow() functions at runtime" if !KUNIT_ALL_TESTS
		depends on KUNIT
		default KUNIT_ALL_TESTS
		help
		Builds unit tests for the check__overflow(), size_(), allocation, and
		related functions.

		For more information on KUnit and unit tests in general please refer
		to the KUnit documentation in Documentation/dev-tools/kunit/.

		If unsure, say N.

		config TEST_UDELAY
		tristate "udelay test driver"
		help

lib/Makefile

+1 −1

Original line number	Diff line number	Diff line
		@@ -77,7 +77,6 @@ obj-$(CONFIG_TEST_LIST_SORT) += test_list_sort.o
		obj-$(CONFIG_TEST_MIN_HEAP) += test_min_heap.o
		obj-$(CONFIG_TEST_LKM) += test_module.o
		obj-$(CONFIG_TEST_VMALLOC) += test_vmalloc.o
		obj-$(CONFIG_TEST_OVERFLOW) += test_overflow.o
		obj-$(CONFIG_TEST_RHASHTABLE) += test_rhashtable.o
		obj-$(CONFIG_TEST_SORT) += test_sort.o
		obj-$(CONFIG_TEST_USER_COPY) += test_user_copy.o
		@@ -363,6 +362,7 @@ obj-$(CONFIG_BITS_TEST) += test_bits.o
		obj-$(CONFIG_CMDLINE_KUNIT_TEST) += cmdline_kunit.o
		obj-$(CONFIG_SLUB_KUNIT_TEST) += slub_kunit.o
		obj-$(CONFIG_MEMCPY_KUNIT_TEST) += memcpy_kunit.o
		obj-$(CONFIG_OVERFLOW_KUNIT_TEST) += overflow_kunit.o

		obj-$(CONFIG_GENERIC_LIB_DEVMEM_IS_ALLOWED) += devmem_is_allowed.o

lib/test_overflow.c→lib/overflow_kunit.c

+249 −305

File changed and moved.

Preview size limit exceeded, changes collapsed.