Commit 612dfce9 authored by Syam Sidhardhan's avatar Syam Sidhardhan Committed by Gustavo Padovan
Browse files

Bluetooth: mgmt: Use __constant when dealing with constants 



__constant_cpu_to_le*() is the right go here.

Signed-off-by: default avatarSyam Sidhardhan <s.syam@samsung.com>
Acked-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: default avatarGustavo Padovan <gustavo.padovan@collabora.co.uk>
parent 258c4ed0

net/bluetooth/mgmt.c

+5 −5
Original line number Diff line number Diff line
@@ -222,7 +222,7 @@ static int cmd_status(struct sock *sk, u16 index, u16 cmd, u8 status) 


	hdr = (void *) skb_put(skb, sizeof(*hdr));



	hdr->opcode = cpu_to_le16(MGMT_EV_CMD_STATUS);

	hdr->opcode = __constant_cpu_to_le16(MGMT_EV_CMD_STATUS);

	hdr->index = cpu_to_le16(index);

	hdr->len = cpu_to_le16(sizeof(*ev));
@@ -253,7 +253,7 @@ static int cmd_complete(struct sock *sk, u16 index, u16 cmd, u8 status, 


	hdr = (void *) skb_put(skb, sizeof(*hdr));



	hdr->opcode = cpu_to_le16(MGMT_EV_CMD_COMPLETE);

	hdr->opcode = __constant_cpu_to_le16(MGMT_EV_CMD_COMPLETE);

	hdr->index = cpu_to_le16(index);

	hdr->len = cpu_to_le16(sizeof(*ev) + rp_len);
@@ -832,7 +832,7 @@ static int mgmt_event(u16 event, struct hci_dev *hdev, void *data, u16 data_len, 
	if (hdev)

		hdr->index = cpu_to_le16(hdev->id);

	else

		hdr->index = cpu_to_le16(MGMT_INDEX_NONE);

		hdr->index = __constant_cpu_to_le16(MGMT_INDEX_NONE);

	hdr->len = cpu_to_le16(data_len);



	if (data)
@@ -3622,9 +3622,9 @@ int mgmt_device_found(struct hci_dev *hdev, bdaddr_t *bdaddr, u8 link_type, 
	ev->addr.type = link_to_bdaddr(link_type, addr_type);

	ev->rssi = rssi;

	if (cfm_name)

		ev->flags |= cpu_to_le32(MGMT_DEV_FOUND_CONFIRM_NAME);

		ev->flags |= __constant_cpu_to_le32(MGMT_DEV_FOUND_CONFIRM_NAME);

	if (!ssp)

		ev->flags |= cpu_to_le32(MGMT_DEV_FOUND_LEGACY_PAIRING);

		ev->flags |= __constant_cpu_to_le32(MGMT_DEV_FOUND_LEGACY_PAIRING);



	if (eir_len > 0)

		memcpy(ev->eir, eir, eir_len);