Commit 610c708b authored by Xuan Zhuo's avatar Xuan Zhuo Committed by Michael S. Tsirkin
Browse files

virtio_ring: check use_dma_api before unmap desc for indirect 



Inside detach_buf_split(), if use_dma_api is false,
vring_unmap_one_split_indirect will be called many times, but actually
nothing is done. So this patch check use_dma_api firstly.

Signed-off-by: default avatarXuan Zhuo <xuanzhuo@linux.alibaba.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
Message-Id: <20230810123057.43407-2-xuanzhuo@linux.alibaba.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 2c9c6371

drivers/virtio/virtio_ring.c

+4 −2
Original line number Diff line number Diff line
@@ -774,8 +774,10 @@ static void detach_buf_split(struct vring_virtqueue *vq, unsigned int head, 
				VRING_DESC_F_INDIRECT));

		BUG_ON(len == 0 || len % sizeof(struct vring_desc));



		if (vq->use_dma_api) {

			for (j = 0; j < len / sizeof(struct vring_desc); j++)

				vring_unmap_one_split_indirect(vq, &indir_desc[j]);

		}



		kfree(indir_desc);

		vq->split.desc_state[head].indir_desc = NULL;