Commit 610bdc04 authored by Matti Vaittinen's avatar Matti Vaittinen Committed by Hans de Goede
Browse files

extcon: extcon-max8997: Fix IRQ freeing at error path 



If reading MAX8997_MUIC_REG_STATUS1 fails at probe the driver exits
without freeing the requested IRQs.

Free the IRQs prior returning if reading the status fails.

Fixes: 3e34c819 ("extcon: max8997: Avoid forcing UART path on drive probe")
Signed-off-by: default avatarMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Acked-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
Link: https://lore.kernel.org/r/27ee4a48ee775c3f8c9d90459c18b6f2b15edc76.1623146580.git.matti.vaittinen@fi.rohmeurope.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 74047eaa

drivers/extcon/extcon-max8997.c

+1 −1
Original line number Diff line number Diff line
@@ -733,7 +733,7 @@ static int max8997_muic_probe(struct platform_device *pdev) 
				2, info->status);

	if (ret) {

		dev_err(info->dev, "failed to read MUIC register\n");

		return ret;

		goto err_irq;

	}

	cable_type = max8997_muic_get_cable_type(info,

					   MAX8997_CABLE_GROUP_ADC, &attached);