Commit 610323d8 authored Apr 01, 2022 by Jakob Koschel Committed by Helge Deller Apr 12, 2022

video: fbdev: mmp: replace usage of found with dedicated list iterator variable

To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].

This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/

 [1]
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>

parent c40b6530

drivers/video/fbdev/mmp/core.c

+5 −6

Original line number	Diff line number	Diff line
		@@ -127,19 +127,18 @@ EXPORT_SYMBOL_GPL(mmp_unregister_panel);
		*/
		struct mmp_path mmp_get_path(const char name)
		{
		struct mmp_path *path;
		int found = 0;
		struct mmp_path path = NULL, iter;

		mutex_lock(&disp_lock);
		list_for_each_entry(path, &path_list, node) {
		if (!strcmp(name, path->name)) {
		found = 1;
		list_for_each_entry(iter, &path_list, node) {
		if (!strcmp(name, iter->name)) {
		path = iter;
		break;
		}
		}
		mutex_unlock(&disp_lock);

		return found ? path : NULL;
		return path;
		}
		EXPORT_SYMBOL_GPL(mmp_get_path);