Commit 60ea006f authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files

perf tools: Get rid of evlist__add_on_all_cpus() 



The cpu and thread maps are properly handled in libperf now.  No need to
do it in the perf tools anymore.  Let's remove the logic.

Reviewed-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20221003204647.1481128-4-namhyung@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 7e2450bb

tools/perf/util/evlist.c

+2 −27
Original line number Diff line number Diff line
@@ -268,28 +268,6 @@ int evlist__add_dummy(struct evlist *evlist) 
	return 0;

}



static void evlist__add_on_all_cpus(struct evlist *evlist, struct evsel *evsel)

{

	evsel->core.system_wide = true;



	/*

	 * All CPUs.

	 *

	 * Note perf_event_open() does not accept CPUs that are not online, so

	 * in fact this CPU list will include only all online CPUs.

	 */

	perf_cpu_map__put(evsel->core.own_cpus);

	evsel->core.own_cpus = perf_cpu_map__new(NULL);

	perf_cpu_map__put(evsel->core.cpus);

	evsel->core.cpus = perf_cpu_map__get(evsel->core.own_cpus);



	/* No threads */

	perf_thread_map__put(evsel->core.threads);

	evsel->core.threads = perf_thread_map__new_dummy();



	evlist__add(evlist, evsel);

}



struct evsel *evlist__add_aux_dummy(struct evlist *evlist, bool system_wide)

{

	struct evsel *evsel = evlist__dummy_event(evlist);
@@ -302,14 +280,11 @@ struct evsel *evlist__add_aux_dummy(struct evlist *evlist, bool system_wide) 
	evsel->core.attr.exclude_hv = 1;

	evsel->core.attr.freq = 0;

	evsel->core.attr.sample_period = 1;

	evsel->core.system_wide = system_wide;

	evsel->no_aux_samples = true;

	evsel->name = strdup("dummy:u");



	if (system_wide)

		evlist__add_on_all_cpus(evlist, evsel);

	else

	evlist__add(evlist, evsel);



	return evsel;

}