Commit 60e7f2c3 authored by Parav Pandit's avatar Parav Pandit Committed by Alex Williamson
Browse files

vfio/mdev: Avoid release parent reference during error path 



During mdev parent registration in mdev_register_device(),
if parent device is duplicate, it releases the reference of existing
parent device.
This is incorrect. Existing parent device should not be touched.

Fixes: 7b96953b ("vfio: Mediated device Core driver")
Reviewed-by: default avatarCornelia Huck <cohuck@redhat.com>
Reviewed-by: default avatarKirti Wankhede <kwankhede@nvidia.com>
Reviewed-by: default avatarMaxim Levitsky <mlevitsk@redhat.com>
Signed-off-by: default avatarParav Pandit <parav@mellanox.com>
Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
parent 2c85f2bd

drivers/vfio/mdev/mdev_core.c

+1 −0
Original line number Diff line number Diff line
@@ -181,6 +181,7 @@ int mdev_register_device(struct device *dev, const struct mdev_parent_ops *ops) 
	/* Check for duplicate */

	parent = __find_parent_device(dev);

	if (parent) {

		parent = NULL;

		ret = -EEXIST;

		goto add_dev_err;

	}