Commit 60bbd9d4 authored by Marek Behún's avatar Marek Behún Committed by Pavel Machek
Browse files

leds: lm36274: use devres LED registering function 



Now that the potential use-after-free issue is resolved we can use
devres for LED registration in this driver.

By using devres version of LED registering function we can remove the
.remove method from this driver.

Signed-off-by: default avatarMarek Behún <marek.behun@nic.cz>
Tested-by: default avatarDan Murphy <dmurphy@ti.com>
Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
parent 5c0d20a9

drivers/leds/leds-lm36274.c

+2 −11
Original line number Diff line number Diff line
@@ -142,7 +142,8 @@ static int lm36274_probe(struct platform_device *pdev) 
	chip->led_dev.max_brightness = MAX_BRIGHTNESS_11BIT;

	chip->led_dev.brightness_set_blocking = lm36274_brightness_set;



	ret = led_classdev_register_ext(chip->dev, &chip->led_dev, &init_data);

	ret = devm_led_classdev_register_ext(chip->dev, &chip->led_dev,

					     &init_data);

	if (ret)

		dev_err(chip->dev, "Failed to register LED for node %pfw\n",

			init_data.fwnode);
@@ -152,15 +153,6 @@ static int lm36274_probe(struct platform_device *pdev) 
	return ret;

}



static int lm36274_remove(struct platform_device *pdev)

{

	struct lm36274 *chip = platform_get_drvdata(pdev);



	led_classdev_unregister(&chip->led_dev);



	return 0;

}



static const struct of_device_id of_lm36274_leds_match[] = {

	{ .compatible = "ti,lm36274-backlight", },

	{},
@@ -169,7 +161,6 @@ MODULE_DEVICE_TABLE(of, of_lm36274_leds_match); 


static struct platform_driver lm36274_driver = {

	.probe  = lm36274_probe,

	.remove = lm36274_remove,

	.driver = {

		.name = "lm36274-leds",

	},