Commit 60aece41 authored by Markus Elfring's avatar Markus Elfring Committed by Michael Ellerman
Browse files

powerpc/82xx: Delete an unnecessary of_node_put() call in pq2ads_pci_init_irq() 



A null pointer would be passed to a call of the function “of_node_put”
immediately after a call of the function “of_find_compatible_node” failed
at one place.
Remove this superfluous function call.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/9c060a41-438b-6fb8-d549-37c72fae4898@web.de
parent 6e7a4da7

arch/powerpc/platforms/82xx/pq2ads-pci-pic.c

+0 −1
Original line number Diff line number Diff line
@@ -123,7 +123,6 @@ int __init pq2ads_pci_init_irq(void) 
	np = of_find_compatible_node(NULL, NULL, "fsl,pq2ads-pci-pic");

	if (!np) {

		printk(KERN_ERR "No pci pic node in device tree.\n");

		of_node_put(np);

		goto out;

	}