Unverified Commit 60adbd8f authored Mar 15, 2021 by Kuninori Morimoto Committed by Mark Brown Mar 19, 2021

ASoC: don't indicate error message for snd_soc_[pcm_]component_xxx()



All snd_soc_component_xxx() and snd_soc_pcm_component_xxx() itself
indicate error message if failed.
Its caller doesn't need to indicate duplicated error message.
This patch removes it.

All snd_soc_component_xxx() indicate error message if failed.
Its caller doesn't need to indicate duplicated error message.
This patch removes it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/878s6puta6.wl-kuninori.morimoto.gx@renesas.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 62462e01

sound/soc/soc-core.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1203,11 +1203,9 @@ static int soc_probe_component(struct snd_soc_card *card,
		}

		ret = snd_soc_component_probe(component);
		if (ret < 0) {
		dev_err(component->dev,
		"ASoC: failed to probe component %d\n", ret);
		if (ret < 0)
		goto err_probe;
		}

		WARN(dapm->idle_bias_off &&
		dapm->bias_level != SND_SOC_BIAS_OFF,
		"codec %s can not start from non-off bias with idle_bias_off==1\n",

sound/soc/soc-pcm.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -2781,11 +2781,8 @@ int soc_new_pcm(struct snd_soc_pcm_runtime *rtd, int num)
		snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &rtd->ops);

		ret = snd_soc_pcm_component_new(rtd);
		if (ret < 0) {
		dev_err(rtd->dev, "ASoC: pcm constructor failed for dailink %s: %d\n",
		rtd->dai_link->name, ret);
		if (ret < 0)
		return ret;
		}

		pcm->no_device_suspend = true;
		out: