Commit 608e8394 authored by Wang ShaoBo's avatar Wang ShaoBo Committed by Yang Yingliang
Browse files

arm64/mpam: resctrl: add tips when rmid modification failed 

hulk inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I4LMMF


CVE: NA

-------------------------------------------------

This adds tips when rmid modification failed.

Fixes: a85aba6a ("mpam: Add support for group rmid modify")
Signed-off-by: default avatarWang ShaoBo <bobo.shaobowang@huawei.com>
Reviewed-by: default avatarCheng Jian <cj.chengjian@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
parent 0f4acaeb

arch/arm64/kernel/mpam/mpam_resctrl.c

+3 −0
Original line number Diff line number Diff line
@@ -1890,12 +1890,14 @@ static ssize_t resctrl_group_rmid_write(struct kernfs_open_file *of, 


	if (rmid == 0 || rdtgrp->mon.rmid == 0) {

		ret = -EINVAL;

		rdt_last_cmd_puts("default rmid 0 is always kept\n");

		goto unlock;

	}



	ret = rmid_to_partid_pmg(rmid, &partid, &pmg);

	if (ret < 0) {

		ret = -EINVAL;

		rdt_last_cmd_puts("invalid rmid\n");

		goto unlock;

	}
@@ -1904,6 +1906,7 @@ static ssize_t resctrl_group_rmid_write(struct kernfs_open_file *of, 


	if (rdtgrp->type != RDTCTRL_GROUP ||

			!list_empty(&rdtgrp->mon.crdtgrp_list)) {

		ret = -EINVAL;

		rdt_last_cmd_puts("unsupported operation\n");

		goto unlock;

	}