Commit 607b1468 authored by farah kassabri's avatar farah kassabri Committed by Oded Gabbay
Browse files

habanalabs: cannot sleep while holding spinlock 



Fix 2 areas in the code where it's possible the code will
go to sleep while holding a spinlock.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarfarah kassabri <fkassabri@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 698f744a

drivers/misc/habanalabs/common/command_buffer.c

+0 −2
Original line number Diff line number Diff line
@@ -314,8 +314,6 @@ int hl_cb_create(struct hl_device *hdev, struct hl_cb_mgr *mgr, 


	spin_lock(&mgr->cb_lock);

	rc = idr_alloc(&mgr->cb_handles, cb, 1, 0, GFP_ATOMIC);

	if (rc < 0)

		rc = idr_alloc(&mgr->cb_handles, cb, 1, 0, GFP_KERNEL);

	spin_unlock(&mgr->cb_lock);



	if (rc < 0) {

drivers/misc/habanalabs/common/memory.c

+1 −1
Original line number Diff line number Diff line
@@ -124,7 +124,7 @@ static int alloc_device_memory(struct hl_ctx *ctx, struct hl_mem_in *args, 


	spin_lock(&vm->idr_lock);

	handle = idr_alloc(&vm->phys_pg_pack_handles, phys_pg_pack, 1, 0,

				GFP_KERNEL);

				GFP_ATOMIC);

	spin_unlock(&vm->idr_lock);



	if (handle < 0) {