Unverified Commit 5ff9556b authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!1672 tty: fix pid memleak in disassociate_ctty() 

Merge Pull Request from: @ci-robot 
 
PR sync from: Yi Yang <yiyang13@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/F3MDGNSS4NARSSKD53VIBRG3ZXPCVNL4/ 
 
https://gitee.com/openeuler/kernel/issues/I7LEZX 
 
Link:https://gitee.com/openeuler/kernel/pulls/1672

 

Reviewed-by: default avatarJialin Zhang <zhangjialin11@huawei.com>
Signed-off-by: default avatarJialin Zhang <zhangjialin11@huawei.com>
parents c07e067c e2944873

drivers/tty/tty_jobctrl.c

+12 −0
Original line number Diff line number Diff line
@@ -308,6 +308,18 @@ void disassociate_ctty(int on_exit) 
		spin_unlock_irqrestore(&tty->ctrl_lock, flags);

		tty_unlock(tty);

		tty_kref_put(tty);



		/*

		 * Race with tty_signal_session_leader(), current->signal

		 * ->tty_old_pgrp may be reassigned, put_pid() again to ensure

		 *  the pid does not leak memory.

		 */

		if (on_exit) {

			spin_lock_irq(&current->sighand->siglock);

			put_pid(current->signal->tty_old_pgrp);

			current->signal->tty_old_pgrp = NULL;

			spin_unlock_irq(&current->sighand->siglock);

		}

	}



	/* Now clear signal->tty under the lock */