Commit 5fe1d61a authored by Guo Zhengkui's avatar Guo Zhengkui Committed by Mauro Carvalho Chehab
Browse files

media: platform: samsung: s5p-jpeg: replace ternary operator with max() 



Fix the following coccicheck warning:

drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c:1712:24-25:
WARNING opportunity for max()

max() macro is defined in include/linux/minmax.h. It avoids multiple
evaluations of the arguments when non-constant and performs strict
type-checking.

Signed-off-by: default avatarGuo Zhengkui <guozhengkui@vivo.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent db9edaaf

drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c

+1 −1
Original line number Diff line number Diff line
@@ -1709,7 +1709,7 @@ static int exynos3250_jpeg_try_downscale(struct s5p_jpeg_ctx *ctx, 
	w_ratio = ctx->out_q.w / r->width;

	h_ratio = ctx->out_q.h / r->height;



	scale_factor = w_ratio > h_ratio ? w_ratio : h_ratio;

	scale_factor = max(w_ratio, h_ratio);

	scale_factor = clamp_val(scale_factor, 1, 8);



	/* Align scale ratio to the nearest power of 2 */