Commit 5fcce743 authored Oct 11, 2006 by Aneesh Kumar Committed by Linus Torvalds Oct 11, 2006

[PATCH] fix lockdep-design.txt



I was looking at lockdep-desing.txt and i guess i am confused with the
changes with respect to fd7bcea3. It
says

+   '.'  acquired while irqs enabled
+   '+'  acquired in irq context
+   '-'  acquired in process context with irqs disabled
+   '?'  read-acquired both with irqs enabled and in irq context
+

But the get_usage_chars() function does this for '-'
 if (class->usage_mask & LOCKF_ENABLED_HARDIRQS)
                        *c1 = '-';

So i guess what would be correct would be
'.'  acquired while irqs disabled
'+'  acquired in irq context
'-'  acquired with irqs enabled
'?' read acquired in irq context with irqs enabled.

Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 3dc3099a

Documentation/lockdep-design.txt

+3 −3

Original line number	Original line	Diff line number	Diff line
	@@ -50,10 +50,10 @@ The bit position indicates hardirq, softirq, hardirq-read,
	softirq-read respectively, and the character displayed in each		softirq-read respectively, and the character displayed in each
	indicates:		indicates:

	'.' acquired while irqs enabled		'.' acquired while irqs disabled
	'+' acquired in irq context		'+' acquired in irq context
	'-' acquired in process context with irqs disabled		'-' acquired with irqs enabled
	'?' read-acquired both with irqs enabled and in irq context		'?' read acquired in irq context with irqs enabled.

	Unused mutexes cannot be part of the cause of an error.		Unused mutexes cannot be part of the cause of an error.