Commit 5fc11a40 authored Dec 08, 2022 by Gavrilov Ilia Committed by Jakub Kicinski Dec 09, 2022

net: devlink: Add missing error check to devlink_resource_put()



When the resource size changes, the return value of the
'nla_put_u64_64bit' function is not checked. That has been fixed to avoid
rechecking at the next step.

Found by InfoTeCS on behalf of Linux Verification Center
(linuxtesting.org) with SVACE.

Note that this is harmless, we'd error out at the next put().

Signed-off-by: Ilia.Gavrilov <Ilia.Gavrilov@infotecs.ru>
Link: https://lore.kernel.org/r/20221208082821.3927937-1-Ilia.Gavrilov@infotecs.ru


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent ce098da1

net/core/devlink.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -4441,9 +4441,10 @@ static int devlink_resource_put(struct devlink devlink, struct sk_buff skb,
		nla_put_u64_64bit(skb, DEVLINK_ATTR_RESOURCE_ID, resource->id,
		DEVLINK_ATTR_PAD))
		goto nla_put_failure;
		if (resource->size != resource->size_new)
		if (resource->size != resource->size_new &&
		nla_put_u64_64bit(skb, DEVLINK_ATTR_RESOURCE_SIZE_NEW,
		resource->size_new, DEVLINK_ATTR_PAD);
		resource->size_new, DEVLINK_ATTR_PAD))
		goto nla_put_failure;
		if (devlink_resource_occ_put(resource, skb))
		goto nla_put_failure;
		if (devlink_resource_size_params_put(resource, skb))