Commit 5fb2864c authored by Andrew Halaney's avatar Andrew Halaney Committed by Viresh Kumar
Browse files

OPP: Properly propagate error along when failing to get icc_path 



fa155f4f ("OPP: Use dev_err_probe() when failing to get icc_path")
failed to actually use the error it was trying to log:

    smatch warnings:
    drivers/opp/of.c:516 dev_pm_opp_of_find_icc_paths() warn: passing zero to 'dev_err_probe'

Make sure to use the right error and pass it along.

Fixes: fa155f4f ("OPP: Use dev_err_probe() when failing to get icc_path")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202306262008.guNLgjt6-lkp@intel.com/


Signed-off-by: default avatarAndrew Halaney <ahalaney@redhat.com>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent fa155f4f

drivers/opp/of.c

+1 −1
Original line number Diff line number Diff line
@@ -513,7 +513,7 @@ int dev_pm_opp_of_find_icc_paths(struct device *dev, 
	for (i = 0; i < num_paths; i++) {

		paths[i] = of_icc_get_by_index(dev, i);

		if (IS_ERR(paths[i])) {

			ret = dev_err_probe(dev, ret, "%s: Unable to get path%d\n", __func__, i);

			ret = dev_err_probe(dev, PTR_ERR(paths[i]), "%s: Unable to get path%d\n", __func__, i);

			goto err;

		}

	}