Commit 5fad5077 authored by Finn Thain's avatar Finn Thain Committed by Damien Le Moal
Browse files

pata_falcon: Avoid type warnings from sparse 



The zero day bot reported some sparse complaints in pata_falcon.c. E.g.

drivers/ata/pata_falcon.c:58:41: warning: cast removes address space '__iomem' of expression
drivers/ata/pata_falcon.c:58:41: warning: incorrect type in argument 1 (different address spaces)
drivers/ata/pata_falcon.c:58:41:    expected unsigned short volatile [noderef] [usertype] __iomem *port
drivers/ata/pata_falcon.c:58:41:    got unsigned short [usertype] *

The same thing shows up in 8 places, all told. Avoid this by removing
unnecessary type casts.

Cc: Jens Axboe <axboe@kernel.dk>
Cc: Michael Schmitz <schmitzmic@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Suggested-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarFinn Thain <fthain@linux-m68k.org>
Reviewed-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
parent d58071a8

drivers/ata/pata_falcon.c

+8 −8
Original line number Diff line number Diff line
@@ -55,14 +55,14 @@ static unsigned int pata_falcon_data_xfer(struct ata_queued_cmd *qc, 
	/* Transfer multiple of 2 bytes */

	if (rw == READ) {

		if (swap)

			raw_insw_swapw((u16 *)data_addr, (u16 *)buf, words);

			raw_insw_swapw(data_addr, (u16 *)buf, words);

		else

			raw_insw((u16 *)data_addr, (u16 *)buf, words);

			raw_insw(data_addr, (u16 *)buf, words);

	} else {

		if (swap)

			raw_outsw_swapw((u16 *)data_addr, (u16 *)buf, words);

			raw_outsw_swapw(data_addr, (u16 *)buf, words);

		else

			raw_outsw((u16 *)data_addr, (u16 *)buf, words);

			raw_outsw(data_addr, (u16 *)buf, words);

	}



	/* Transfer trailing byte, if any. */
@@ -74,16 +74,16 @@ static unsigned int pata_falcon_data_xfer(struct ata_queued_cmd *qc, 


		if (rw == READ) {

			if (swap)

				raw_insw_swapw((u16 *)data_addr, (u16 *)pad, 1);

				raw_insw_swapw(data_addr, (u16 *)pad, 1);

			else

				raw_insw((u16 *)data_addr, (u16 *)pad, 1);

				raw_insw(data_addr, (u16 *)pad, 1);

			*buf = pad[0];

		} else {

			pad[0] = *buf;

			if (swap)

				raw_outsw_swapw((u16 *)data_addr, (u16 *)pad, 1);

				raw_outsw_swapw(data_addr, (u16 *)pad, 1);

			else

				raw_outsw((u16 *)data_addr, (u16 *)pad, 1);

				raw_outsw(data_addr, (u16 *)pad, 1);

		}

		words++;

	}