Commit 5f9fa8a6 authored by Ingo Molnar's avatar Ingo Molnar
Browse files

lockdep: make cli/sti annotation warnings clearer 



make cli/sti annotation warnings easier to interpret.

Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
Signed-off-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
parent f194d132

kernel/lockdep.c

+9 −4
Original line number Diff line number Diff line
@@ -2654,10 +2654,15 @@ static void check_flags(unsigned long flags) 
	if (!debug_locks)

		return;



	if (irqs_disabled_flags(flags))

		DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled);

	else

		DEBUG_LOCKS_WARN_ON(!current->hardirqs_enabled);

	if (irqs_disabled_flags(flags)) {

		if (DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled)) {

			printk("possible reason: unannotated irqs-off.\n");

		}

	} else {

		if (DEBUG_LOCKS_WARN_ON(!current->hardirqs_enabled)) {

			printk("possible reason: unannotated irqs-on.\n");

		}

	}



	/*

	 * We dont accurately track softirq state in e.g.