Commit 5f8f9567 authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf evlist: Remove group option. 



The group option predates grouping events using curly braces added in
commit 89efb029 ("perf tools: Add support to parse event group
syntax").

The --group option was retained for legacy support (in August
2012) but keeping it adds complexity.

Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Athira Jajeev <atrajeev@linux.vnet.ibm.com>
Cc: Eelco Chaudron <echaudro@redhat.com>
Cc: German Gomez <german.gomez@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Kim Phillips <kim.phillips@amd.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Riccardo Mancini <rickyman7@gmail.com>
Cc: Sandipan Das <sandipan.das@amd.com>
Cc: Sean Christopherson <seanjc@google.com>
Cc: Shaomin Deng <dengshaomin@cdjrlc.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Timothy Hayes <timothy.hayes@arm.com>
Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>
Cc: bpf@vger.kernel.org
Link: https://lore.kernel.org/r/20221213232651.1269909-6-irogers@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent caec5470

tools/perf/Documentation/perf-record.txt

+0 −4
Original line number Diff line number Diff line
@@ -238,10 +238,6 @@ OPTIONS 
	Also, by adding a comma, the number of mmap pages for AUX

	area tracing can be specified.



--group::

	Put all events in a single event group.  This precedes the --event

	option and remains only for backward compatibility.  See --event.



-g::

	Enables call-graph (stack chain/backtrace) recording for both

	kernel space and user space.

tools/perf/Documentation/perf-top.txt

+2 −5
Original line number Diff line number Diff line
@@ -51,9 +51,6 @@ Default is to monitor all CPUS. 
--count-filter=<count>::

	Only display functions with more events than this.



--group::

        Put the counters into a counter group.



--group-sort-idx::

	Sort the output by the event at the index n in group. If n is invalid,

	sort by the first event. It can support multiple groups with different
@@ -313,10 +310,10 @@ use '-e e1 -e e2 -G foo,foo' or just use '-e e1 -e e2 -G foo'. 


		perf top -e cycles,probe:icmp_rcv --switch-on=probe:icmp_rcv



	   Alternatively one can ask for --group and then two overhead columns

	   Alternatively one can ask for a group and then two overhead columns

           will appear, the first for cycles and the second for the switch-on event.



		perf top --group -e cycles,probe:icmp_rcv --switch-on=probe:icmp_rcv

		perf top -e '{cycles,probe:icmp_rcv}' --switch-on=probe:icmp_rcv



	This may be interesting to measure a workload only after some initialization

	phase is over, i.e. insert a perf probe at that point and use the above

tools/perf/builtin-record.c

+0 −2
Original line number Diff line number Diff line
@@ -3380,8 +3380,6 @@ static struct option __record_options[] = { 
	OPT_CALLBACK(0, "mmap-flush", &record.opts, "number",

		     "Minimal number of bytes that is extracted from mmap data pages (default: 1)",

		     record__mmap_flush_parse),

	OPT_BOOLEAN(0, "group", &record.opts.group,

		    "put the counters into a counter group"),

	OPT_CALLBACK_NOOPT('g', NULL, &callchain_param,

			   NULL, "enables call-graph recording" ,

			   &record_callchain_opt),

tools/perf/builtin-stat.c

+0 −6
Original line number Diff line number Diff line
@@ -181,7 +181,6 @@ static bool topdown_run = false; 
static bool			smi_cost			= false;

static bool			smi_reset			= false;

static int			big_num_opt			=  -1;

static bool			group				= false;

static const char		*pre_cmd			= NULL;

static const char		*post_cmd			= NULL;

static bool			sync_run			= false;
@@ -781,9 +780,6 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx) 
		child_pid = evsel_list->workload.pid;

	}



	if (group)

		evlist__set_leader(evsel_list);



	if (!cpu_map__is_dummy(evsel_list->core.user_requested_cpus)) {

		if (affinity__setup(&saved_affinity) < 0)

			return -1;
@@ -1192,8 +1188,6 @@ static struct option stat_options[] = { 
#endif

	OPT_BOOLEAN('a', "all-cpus", &target.system_wide,

		    "system-wide collection from all CPUs"),

	OPT_BOOLEAN('g', "group", &group,

		    "put the counters into a counter group"),

	OPT_BOOLEAN(0, "scale", &stat_config.scale,

		    "Use --no-scale to disable counter scaling for multiplexing"),

	OPT_INCR('v', "verbose", &verbose,

tools/perf/builtin-top.c

+0 −2
Original line number Diff line number Diff line
@@ -1471,8 +1471,6 @@ int cmd_top(int argc, const char **argv) 
			    "dump the symbol table used for profiling"),

	OPT_INTEGER('f', "count-filter", &top.count_filter,

		    "only display functions with more events than this"),

	OPT_BOOLEAN(0, "group", &opts->group,

			    "put the counters into a counter group"),

	OPT_BOOLEAN('i', "no-inherit", &opts->no_inherit,

		    "child tasks do not inherit counters"),

	OPT_STRING(0, "sym-annotate", &top.sym_filter, "symbol name",