Commit 5f86cce6 authored by Mateusz Jończyk's avatar Mateusz Jończyk Committed by Guenter Roeck
Browse files

hwmon: (dell-smm) rewrite CONFIG_I8K description 

It is not the laptops, but the /proc/i8k interface that is legacy (or so
I think was the intention of the help text author). The old description
was confusing, fix this.

The phrase "Say Y if you intend to run this kernel on old Dell laptops
or want to use userspace package i8kutils." was introduced in 2015, in
commit 039ae585 ("hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k")

I think that "old laptops" was about hotkey and Fn key support - this
driver in the 2.4 kernels' era apparently had these capabilities
(see: https://github.com/vitorafsr/i8kutils

 , description of
"repeat_rate" kernel module parameter).

Signed-off-by: default avatarMateusz Jończyk <mat.jonczyk@o2.pl>
Cc: Pali Rohár <pali@kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Mark Gross <markgross@kernel.org>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/r/20220212125654.357408-2-mat.jonczyk@o2.pl


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent a7a6f65a

drivers/hwmon/Kconfig

+8 −9
Original line number Diff line number Diff line
@@ -507,19 +507,18 @@ config SENSORS_DELL_SMM 
	  userspace interface for i8kutils package.



config I8K

	bool "Dell i8k legacy laptop support"

	bool "Legacy /proc/i8k interface of Dell laptop SMM BIOS hwmon driver"

	depends on SENSORS_DELL_SMM

	depends on PROC_FS

	help

	  This option enables legacy /proc/i8k userspace interface in hwmon

	  dell-smm-hwmon driver. Character file /proc/i8k reports bios version,

	  temperature and allows controlling fan speeds of Dell laptops via

	  System Management Mode. For old Dell laptops (like Dell Inspiron 8000)

	  it reports also power and hotkey status. For fan speed control is

	  needed userspace package i8kutils.

	  This option enables the legacy /proc/i8k userspace interface of the

	  dell-smm-hwmon driver. The character file /proc/i8k exposes the BIOS

	  version, temperatures and allows control of fan speeds of some Dell

	  laptops. Sometimes it also reports power and hotkey status.



	  Say Y if you intend to run this kernel on old Dell laptops or want to

	  use userspace package i8kutils.

	  This interface is required to run programs from the i8kutils package.



	  Say Y if you intend to run userspace programs that use this interface.

	  Say N otherwise.



config SENSORS_DA9052_ADC