Commit 5f80d6bd authored by Jaroslav Kysela's avatar Jaroslav Kysela Committed by Takashi Iwai
Browse files

ALSA: hda/hdmi: Fix the converter reuse for the silent stream 



When the user space pcm stream uses the silent stream converter,
it is no longer allocated for the silent stream. Clear the appropriate
flag in the hdmi_pcm_open() function. The silent stream setup may
be applied in hdmi_pcm_close() (and the error path - open fcn) again.

If the flag is not cleared, the reuse conditions for the silent
stream converter in hdmi_choose_cvt() may improperly share
this converter.

Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: default avatarJaroslav Kysela <perex@perex.cz>
Link: https://lore.kernel.org/r/20220913070216.3233974-1-perex@perex.cz


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent ba1f8180

sound/pci/hda/patch_hdmi.c

+1 −0
Original line number Diff line number Diff line
@@ -1278,6 +1278,7 @@ static int hdmi_pcm_open(struct hda_pcm_stream *hinfo, 
	set_bit(pcm_idx, &spec->pcm_in_use);

	per_pin = get_pin(spec, pin_idx);

	per_pin->cvt_nid = per_cvt->cvt_nid;

	per_pin->silent_stream = false;

	hinfo->nid = per_cvt->cvt_nid;



	/* flip stripe flag for the assigned stream if supported */