Commit 5f7ef487 authored by Dan Carpenter's avatar Dan Carpenter Committed by Song Liu
Browse files

md/raid5: missing error code in setup_conf() 



Return -ENOMEM if the allocation fails.  Don't return success.

Fixes: 8fbcba6b ("md/raid5: Cleanup setup_conf() error returns")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarLogan Gunthorpe <logang@deltatee.com>
Signed-off-by: default avatarSong Liu <song@kernel.org>
parent 957a2b34

drivers/md/raid5.c

+3 −1
Original line number Diff line number Diff line
@@ -7304,7 +7304,9 @@ static struct r5conf *setup_conf(struct mddev *mddev) 
		goto abort;

	conf->mddev = mddev;



	if ((conf->stripe_hashtbl = kzalloc(PAGE_SIZE, GFP_KERNEL)) == NULL)

	ret = -ENOMEM;

	conf->stripe_hashtbl = kzalloc(PAGE_SIZE, GFP_KERNEL);

	if (!conf->stripe_hashtbl)

		goto abort;



	/* We init hash_locks[0] separately to that it can be used