Commit 5f54237a authored by Deren Wu's avatar Deren Wu Committed by Felix Fietkau
Browse files

wifi: mt76: add memory barrier to SDIO queue kick 



Ensure the entry has been fully updated before SDIO bus worker access
it. This patch would fix potential memory risk in both mt7663s and
mt7921s.

Fixes: 764dee47 ("mt76: sdio: move common code in mt76_sdio module")
Signed-off-by: default avatarDeren Wu <deren.wu@mediatek.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent 09f4417a

drivers/net/wireless/mediatek/mt76/sdio.c

+4 −0
Original line number Diff line number Diff line
@@ -562,6 +562,10 @@ mt76s_tx_queue_skb_raw(struct mt76_dev *dev, struct mt76_queue *q, 


	q->entry[q->head].buf_sz = len;

	q->entry[q->head].skb = skb;



	/* ensure the entry fully updated before bus access */

	smp_wmb();



	q->head = (q->head + 1) % q->ndesc;

	q->queued++;