Commit 5f432cce authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

nvme: use blk_mq_alloc_disk 



Switch to use the blk_mq_alloc_disk helper for allocating the
request_queue and gendisk.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarKeith Busch <kbusch@kernel.org>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Link: https://lore.kernel.org/r/20210816131910.615153-2-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 759e0fd4

drivers/nvme/host/core.c

+13 −20
Original line number Diff line number Diff line
@@ -3728,9 +3728,14 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid, 
	if (!ns)

		goto out_free_id;



	ns->queue = blk_mq_init_queue(ctrl->tagset);

	if (IS_ERR(ns->queue))

	disk = blk_mq_alloc_disk(ctrl->tagset, ns);

	if (IS_ERR(disk))

		goto out_free_ns;

	disk->fops = &nvme_bdev_ops;

	disk->private_data = ns;



	ns->disk = disk;

	ns->queue = disk->queue;



	if (ctrl->opts && ctrl->opts->data_digest)

		blk_queue_flag_set(QUEUE_FLAG_STABLE_WRITES, ns->queue);
@@ -3739,20 +3744,12 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid, 
	if (ctrl->ops->flags & NVME_F_PCI_P2PDMA)

		blk_queue_flag_set(QUEUE_FLAG_PCI_P2PDMA, ns->queue);



	ns->queue->queuedata = ns;

	ns->ctrl = ctrl;

	kref_init(&ns->kref);



	if (nvme_init_ns_head(ns, nsid, ids, id->nmic & NVME_NS_NMIC_SHARED))

		goto out_free_queue;

		goto out_cleanup_disk;



	disk = alloc_disk_node(0, node);

	if (!disk)

		goto out_unlink_ns;



	disk->fops = &nvme_bdev_ops;

	disk->private_data = ns;

	disk->queue = ns->queue;

	/*

	 * Without the multipath code enabled, multiple controller per

	 * subsystems are visible as devices and thus we cannot use the
@@ -3761,15 +3758,14 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid, 
	if (!nvme_mpath_set_disk_name(ns, disk->disk_name, &disk->flags))

		sprintf(disk->disk_name, "nvme%dn%d", ctrl->instance,

			ns->head->instance);

	ns->disk = disk;



	if (nvme_update_ns_info(ns, id))

		goto out_put_disk;

		goto out_unlink_ns;



	if ((ctrl->quirks & NVME_QUIRK_LIGHTNVM) && id->vs[0] == 0x1) {

		if (nvme_nvm_register(ns, disk->disk_name, node)) {

			dev_warn(ctrl->device, "LightNVM init failure\n");

			goto out_put_disk;

			goto out_unlink_ns;

		}

	}
@@ -3788,10 +3784,7 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid, 
	kfree(id);



	return;

 out_put_disk:

	/* prevent double queue cleanup */

	ns->disk->queue = NULL;

	put_disk(ns->disk);



 out_unlink_ns:

	mutex_lock(&ctrl->subsys->lock);

	list_del_rcu(&ns->siblings);
@@ -3799,8 +3792,8 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid, 
		list_del_init(&ns->head->entry);

	mutex_unlock(&ctrl->subsys->lock);

	nvme_put_ns_head(ns->head);

 out_free_queue:

	blk_cleanup_queue(ns->queue);

 out_cleanup_disk:

	blk_cleanup_disk(disk);

 out_free_ns:

	kfree(ns);

 out_free_id: