Unverified Commit 5f3d94eb authored by Tom Rix's avatar Tom Rix Committed by Mark Brown
Browse files

ASoC: nau8825: fix bounds check for adc_delay 



clang build reports
sound/soc/codecs/nau8825.c:2826:31: error: overlapping comparisons
  always evaluate to false [-Werror,-Wtautological-overlap-compare]
        if (nau8825->adc_delay < 125 && nau8825->adc_delay > 500)
            ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~

This is a bug, a logical-or should have been used.

Fixes: fc0b096c ("ASoC: nau8825: Add delay control for input path")
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Acked-by: default avatarDavid Lin <CTLIN0@nuvoton.com>
Link: https://lore.kernel.org/r/20230418120955.3230705-1-trix@redhat.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 67380533

sound/soc/codecs/nau8825.c

+1 −1
Original line number Diff line number Diff line
@@ -2823,7 +2823,7 @@ static int nau8825_read_device_properties(struct device *dev, 
	ret = device_property_read_u32(dev, "nuvoton,adc-delay-ms", &nau8825->adc_delay);

	if (ret)

		nau8825->adc_delay = 125;

	if (nau8825->adc_delay < 125 && nau8825->adc_delay > 500)

	if (nau8825->adc_delay < 125 || nau8825->adc_delay > 500)

		dev_warn(dev, "Please set the suitable delay time!\n");



	nau8825->mclk = devm_clk_get(dev, "mclk");