Commit 5f340402 authored by Tudor Ambarus's avatar Tudor Ambarus
Browse files

mtd: spi-nor: Remove debugfs entries that duplicate sysfs entries 



SPI NOR sysfs defines partname and jedec_id device attributes, which
duplicate the information from debugfs. Since the sysfs directory
structure and the attributes in each directory define an ABI between the
kernel and user space, thus it can never be removed, remove the debugfs
entries so that we don't duplicate the information.

Signed-off-by: default avatarTudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: default avatarPratyush Yadav <p.yadav@ti.com>
Link: https://lore.kernel.org/r/20211217122636.474976-2-tudor.ambarus@microchip.com
parent 9de3cb1c

drivers/mtd/spi-nor/core.c

+0 −12
Original line number Diff line number Diff line
@@ -3126,16 +3126,6 @@ static const struct flash_info *spi_nor_match_id(struct spi_nor *nor, 
	return NULL;

}



static void spi_nor_debugfs_init(struct spi_nor *nor,

				 const struct flash_info *info)

{

	struct mtd_info *mtd = &nor->mtd;



	mtd->dbg.partname = info->name;

	mtd->dbg.partid = devm_kasprintf(nor->dev, GFP_KERNEL, "spi-nor:%*phN",

					 info->id_len, info->id);

}



static const struct flash_info *spi_nor_get_flash_info(struct spi_nor *nor,

						       const char *name)

{
@@ -3243,8 +3233,6 @@ int spi_nor_scan(struct spi_nor *nor, const char *name, 


	nor->info = info;



	spi_nor_debugfs_init(nor, info);



	mutex_init(&nor->lock);



	/* Init flash parameters based on flash_info struct and SFDP */