Commit 5f1c7031 authored by Zhang Shurong's avatar Zhang Shurong Committed by Greg Kroah-Hartman
Browse files

staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext() 



The "exc->key_len" is a u16 that comes from the user.  If it's over
IW_ENCODING_TOKEN_MAX (64) that could lead to memory corruption.

Fixes: b121d848 ("staging: ks7010: simplify calls to memcpy()")
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarZhang Shurong <zhang_shurong@foxmail.com>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/tencent_5153B668C0283CAA15AA518325346E026A09@qq.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4912649e

drivers/staging/ks7010/ks_wlan_net.c

+4 −2
Original line number Diff line number Diff line
@@ -1583,8 +1583,10 @@ static int ks_wlan_set_encode_ext(struct net_device *dev, 
			commit |= SME_WEP_FLAG;

		}

		if (enc->key_len) {

			memcpy(&key->key_val[0], &enc->key[0], enc->key_len);

			key->key_len = enc->key_len;

			int key_len = clamp_val(enc->key_len, 0, IW_ENCODING_TOKEN_MAX);



			memcpy(&key->key_val[0], &enc->key[0], key_len);

			key->key_len = key_len;

			commit |= (SME_WEP_VAL1 << index);

		}

		break;