Commit 5ee6ad1d authored by Guo Zhengkui's avatar Guo Zhengkui Committed by David S. Miller
Browse files

ipv6: exthdrs: use swap() instead of open coding it 



Address the following coccicheck warning:
net/ipv6/exthdrs.c:620:44-45: WARNING opportunity for swap()

by using swap() for the swapping of variable values and drop
the tmp (`addr`) variable that is not needed any more.

Signed-off-by: default avatarGuo Zhengkui <guozhengkui@vivo.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 816cda9a

net/ipv6/exthdrs.c

+1 −4
Original line number Diff line number Diff line
@@ -487,7 +487,6 @@ static int ipv6_rpl_srh_rcv(struct sk_buff *skb) 
	struct net *net = dev_net(skb->dev);

	struct inet6_dev *idev;

	struct ipv6hdr *oldhdr;

	struct in6_addr addr;

	unsigned char *buf;

	int accept_rpl_seg;

	int i, err;
@@ -616,9 +615,7 @@ static int ipv6_rpl_srh_rcv(struct sk_buff *skb) 
		return -1;

	}



	addr = ipv6_hdr(skb)->daddr;

	ipv6_hdr(skb)->daddr = ohdr->rpl_segaddr[i];

	ohdr->rpl_segaddr[i] = addr;

	swap(ipv6_hdr(skb)->daddr, ohdr->rpl_segaddr[i]);



	ipv6_rpl_srh_compress(chdr, ohdr, &ipv6_hdr(skb)->daddr, n);