Unverified Commit 5ea90b2b authored Sep 13, 2024 by openeuler-ci-bot Committed by Gitee Sep 13, 2024

!11458 usb: gadget: core: Check for unset descriptor

Merge Pull Request from: @ci-robot 
 
PR sync from: Ye Bin <yebin10@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/PJOTNSCP5PPPGCVCI6NF6BERLJOJVAUZ/ 
 
https://gitee.com/src-openeuler/kernel/issues/IAOXZ1 
 
Link:https://gitee.com/openeuler/kernel/pulls/11458

 

Reviewed-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

parents 691cdd68 34d17c88

drivers/usb/gadget/udc/core.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -99,12 +99,10 @@ int usb_ep_enable(struct usb_ep *ep)
		goto out;

		/* UDC drivers can't handle endpoints with maxpacket size 0 */
		if (usb_endpoint_maxp(ep->desc) == 0) {
		/*
		* We should log an error message here, but we can't call
		* dev_err() because there's no way to find the gadget
		* given only ep.
		*/
		if (!ep->desc \|\| usb_endpoint_maxp(ep->desc) == 0) {
		WARN_ONCE(1, "%s: ep%d (%s) has %s\n", __func__, ep->address, ep->name,
		(!ep->desc) ? "NULL descriptor" : "maxpacket 0");

		ret = -EINVAL;
		goto out;
		}