Commit 5e74a4b3 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Paolo Abeni
Browse files

stmmac: intel: Fix an error handling path in intel_eth_pci_probe() 



When the managed API is used, there is no need to explicitly call
pci_free_irq_vectors().

This looks to be a left-over from the commit in the Fixes tag. Only the
.remove() function had been updated.

So remove this unused function call and update goto label accordingly.

Fixes: 8accc467 ("stmmac: intel: use managed PCI function on probe and resume")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarWong Vee Khee <vee.khee.wong@linux.intel.com>
Link: https://lore.kernel.org/r/1ac9b6787b0db83b0095711882c55c77c8ea8da0.1654462241.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent b8d91399

drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c

+1 −3
Original line number Diff line number Diff line
@@ -1072,13 +1072,11 @@ static int intel_eth_pci_probe(struct pci_dev *pdev, 


	ret = stmmac_dvr_probe(&pdev->dev, plat, &res);

	if (ret) {

		goto err_dvr_probe;

		goto err_alloc_irq;

	}



	return 0;



err_dvr_probe:

	pci_free_irq_vectors(pdev);

err_alloc_irq:

	clk_disable_unprepare(plat->stmmac_clk);

	clk_unregister_fixed_rate(plat->stmmac_clk);