Commit 5e6b8a50 authored May 26, 2021 by Yang Yingliang Committed by Eric W. Biederman May 28, 2021

cred: add missing return error code when set_cred_ucounts() failed



If set_cred_ucounts() failed, we need return the error code.

Fixes: 905ae01c ("Add a reference to ucounts for each cred")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lkml.kernel.org/r/20210526143805.2549649-1-yangyingliang@huawei.com


Reviewed-by: Alexey Gladkov <legion@kernel.org>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>

parent f928ef68

kernel/cred.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -372,7 +372,8 @@ int copy_creds(struct task_struct *p, unsigned long clone_flags)
		ret = create_user_ns(new);
		if (ret < 0)
		goto error_put;
		if (set_cred_ucounts(new) < 0)
		ret = set_cred_ucounts(new);
		if (ret < 0)
		goto error_put;
		}