Commit 5e469dac authored by Sudeep Holla's avatar Sudeep Holla
Browse files

firmware: arm_scmi: Ensure drivers provide a probe function 

The bus probe callback calls the driver callback without further
checking. Better be safe than sorry and refuse registration of a driver
without a probe function to prevent a NULL pointer exception.

Link: https://lore.kernel.org/r/20210624095059.4010157-2-sudeep.holla@arm.com


Fixes: 933c5044 ("firmware: arm_scmi: add scmi protocol bus to enumerate protocol devices")
Reported-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tested-by: default avatarCristian Marussi <cristian.marussi@arm.com>
Reviewed-by: default avatarCristian Marussi <cristian.marussi@arm.com>
Acked-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent 38e0c992

drivers/firmware/arm_scmi/bus.c

+3 −0
Original line number Diff line number Diff line
@@ -134,6 +134,9 @@ int scmi_driver_register(struct scmi_driver *driver, struct module *owner, 
{

	int retval;



	if (!driver->probe)

		return -EINVAL;



	retval = scmi_protocol_device_request(driver->id_table);

	if (retval)

		return retval;