Commit 5e25a8cd authored Jan 05, 2023 by Roderick Colenbrander Committed by Jiri Kosina Jan 18, 2023

HID: playstation: fix DualShock4 unreachable calibration code.



Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Reported-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 4f1f3918

drivers/hid/hid-playstation.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -1759,11 +1759,10 @@ static int dualshock4_get_calibration_data(struct dualshock4 *ds4)
		if (retries < 2) {
		hid_warn(hdev, "Retrying DualShock 4 get calibration report (0x02) request\n");
		continue;
		} else {
		ret = -EILSEQ;
		goto err_free;
		}

		hid_err(hdev, "Failed to retrieve DualShock4 calibration info: %d\n", ret);
		ret = -EILSEQ;
		goto err_free;
		} else {
		break;