Commit 5e1bfb27 authored by Alisa Khabibrakhmanova's avatar Alisa Khabibrakhmanova Committed by Daniel Vetter
Browse files

drm/via: Add new condition to via_dma_cleanup() 



Pointer dev_priv->mmio, which was checked for NULL at via_do_init_map(),
is passed to via_do_cleanup_map() and is dereferenced there without check.

The patch adds the condition in via_dma_cleanup() which prevents potential NULL
pointer dereference.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 22f579c6 ("drm: Add via unichrome support")
Signed-off-by: default avatarAlisa Khabibrakhmanova <khabibrakhmanova@ispras.ru>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20220729090643.240778-1-khabibrakhmanova@ispras.ru
parent 07d50b82

drivers/gpu/drm/via/via_dri1.c

+1 −1
Original line number Diff line number Diff line
@@ -2961,7 +2961,7 @@ int via_dma_cleanup(struct drm_device *dev) 
		drm_via_private_t *dev_priv =

		    (drm_via_private_t *) dev->dev_private;



		if (dev_priv->ring.virtual_start) {

		if (dev_priv->ring.virtual_start && dev_priv->mmio) {

			via_cmdbuf_reset(dev_priv);



			drm_legacy_ioremapfree(&dev_priv->ring.map, dev);