Commit 5e1a3262 authored by Theodore Ts'o's avatar Theodore Ts'o Committed by sanglipeng
Browse files

ext4: only check dquot_initialize_needed() when debugging 

stable inclusion
from stable-v5.10.184
commit 1b4b3350969e0d56363eaa0f46bd0c1d07b066d8
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I8IRR2

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=1b4b3350969e0d56363eaa0f46bd0c1d07b066d8

--------------------------------

commit dea9d8f7 upstream.

ext4_xattr_block_set() relies on its caller to call dquot_initialize()
on the inode.  To assure that this has happened there are WARN_ON
checks.  Unfortunately, this is subject to false positives if there is
an antagonist thread which is flipping the file system at high rates
between r/o and rw.  So only do the check if EXT4_XATTR_DEBUG is
enabled.

Link: https://lore.kernel.org/r/20230608044056.GA1418535@mit.edu


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarsanglipeng <sanglipeng1@jd.com>
parent 46293fc6

fs/ext4/xattr.c

+4 −2
Original line number Diff line number Diff line
@@ -2002,8 +2002,9 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode, 
			else {

				u32 ref;



#ifdef EXT4_XATTR_DEBUG

				WARN_ON_ONCE(dquot_initialize_needed(inode));



#endif

				/* The old block is released after updating

				   the inode. */

				error = dquot_alloc_block(inode,
@@ -2065,8 +2066,9 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode, 
			/* We need to allocate a new block */

			ext4_fsblk_t goal, block;



#ifdef EXT4_XATTR_DEBUG

			WARN_ON_ONCE(dquot_initialize_needed(inode));



#endif

			goal = ext4_group_first_block_no(sb,

						EXT4_I(inode)->i_block_group);

			block = ext4_new_meta_blocks(handle, inode, goal, 0,