Commit 5d9224fb authored by Xiang Chen's avatar Xiang Chen Committed by Martin K. Petersen
Browse files

scsi: hisi_sas: Remove unused variable and check in hisi_sas_send_ata_reset_each_phy() 

In commit 29e2bac8 ("scsi: hisi_sas: Fix some issues related to
asd_sas_port->phy_list"), we use asd_sas_port->phy_mask instead of
accessing asd_sas_port->phy_list, and it is enough to use
asd_sas_port->phy_mask to check the state of phy, so remove the unused
check and variable.

Link: https://lore.kernel.org/r/1641300126-53574-1-git-send-email-chenxiang66@hisilicon.com


Fixes: 29e2bac8 ("scsi: hisi_sas: Fix some issues related to asd_sas_port->phy_list")
Reported-by: default avatarNathan Chancellor <nathan@kernel.org>
Reported-by: default avatarColin King <colin.i.king@gmail.com>
Acked-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarXiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent c3b48443

drivers/scsi/hisi_sas/hisi_sas_main.c

+0 −5
Original line number Diff line number Diff line
@@ -1525,16 +1525,11 @@ static void hisi_sas_send_ata_reset_each_phy(struct hisi_hba *hisi_hba, 
	struct device *dev = hisi_hba->dev;

	int s = sizeof(struct host_to_dev_fis);

	int rc = TMF_RESP_FUNC_FAILED;

	struct asd_sas_phy *sas_phy;

	struct ata_link *link;

	u8 fis[20] = {0};

	u32 state;

	int i;



	state = hisi_hba->hw->get_phys_state(hisi_hba);

	for (i = 0; i < hisi_hba->n_phy; i++) {

		if (!(state & BIT(sas_phy->id)))

			continue;

		if (!(sas_port->phy_mask & BIT(i)))

			continue;