Commit 5d8f384a authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Rafael J. Wysocki
Browse files

cpufreq: davinci: Fix clk use after free 



The remove function first frees the clks and only then calls
cpufreq_unregister_driver(). If one of the cpufreq callbacks is called
just before cpufreq_unregister_driver() is run, the freed clks might be
used.

Fixes: 6601b803 ("davinci: add generic CPUFreq driver for DaVinci")
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 7cca9a98

drivers/cpufreq/davinci-cpufreq.c

+2 −2
Original line number Diff line number Diff line
@@ -133,13 +133,13 @@ static int __init davinci_cpufreq_probe(struct platform_device *pdev) 


static int __exit davinci_cpufreq_remove(struct platform_device *pdev)

{

	cpufreq_unregister_driver(&davinci_driver);



	clk_put(cpufreq.armclk);



	if (cpufreq.asyncclk)

		clk_put(cpufreq.asyncclk);



	cpufreq_unregister_driver(&davinci_driver);



	return 0;

}