Unverified Commit 5d5e3280 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!9080 Bluetooth: L2CAP: Fix not validating setsockopt user input 

Merge Pull Request from: @ci-robot 
 
PR sync from: Kaixiong Yu <yukaixiong@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/7CA4VQ7QKFC7JEF6CWHWFJJFALQTUSHM/ 
 
https://gitee.com/src-openeuler/kernel/issues/I9QRQE 
 
Link:https://gitee.com/openeuler/kernel/pulls/9080

 

Reviewed-by: default avatarYue Haibing <yuehaibing@huawei.com>
Signed-off-by: default avatarJialin Zhang <zhangjialin11@huawei.com>
parents afd8fa78 a028201f

net/bluetooth/l2cap_sock.c

+20 −32
Original line number Diff line number Diff line
@@ -744,7 +744,7 @@ static int l2cap_sock_setsockopt_old(struct socket *sock, int optname, 
	struct sock *sk = sock->sk;

	struct l2cap_chan *chan = l2cap_pi(sk)->chan;

	struct l2cap_options opts;

	int len, err = 0;

	int err = 0;

	u32 opt;



	BT_DBG("sk %p", sk);
@@ -771,11 +771,9 @@ static int l2cap_sock_setsockopt_old(struct socket *sock, int optname, 
		opts.max_tx   = chan->max_tx;

		opts.txwin_size = chan->tx_win;



		len = min_t(unsigned int, sizeof(opts), optlen);

		if (copy_from_sockptr(&opts, optval, len)) {

			err = -EFAULT;

		err = bt_copy_from_sockptr(&opts, sizeof(opts), optval, optlen);

		if (err)

			break;

		}



		if (opts.txwin_size > L2CAP_DEFAULT_EXT_WINDOW) {

			err = -EINVAL;
@@ -818,10 +816,9 @@ static int l2cap_sock_setsockopt_old(struct socket *sock, int optname, 
		break;



	case L2CAP_LM:

		if (copy_from_sockptr(&opt, optval, sizeof(u32))) {

			err = -EFAULT;

		err = bt_copy_from_sockptr(&opt, sizeof(opt), optval, optlen);

		if (err)

			break;

		}



		if (opt & L2CAP_LM_FIPS) {

			err = -EINVAL;
@@ -902,7 +899,7 @@ static int l2cap_sock_setsockopt(struct socket *sock, int level, int optname, 
	struct bt_security sec;

	struct bt_power pwr;

	struct l2cap_conn *conn;

	int len, err = 0;

	int err = 0;

	u32 opt;

	u16 mtu;

	u8 mode;
@@ -928,11 +925,9 @@ static int l2cap_sock_setsockopt(struct socket *sock, int level, int optname, 


		sec.level = BT_SECURITY_LOW;



		len = min_t(unsigned int, sizeof(sec), optlen);

		if (copy_from_sockptr(&sec, optval, len)) {

			err = -EFAULT;

		err = bt_copy_from_sockptr(&sec, sizeof(sec), optval, optlen);

		if (err)

			break;

		}



		if (sec.level < BT_SECURITY_LOW ||

		    sec.level > BT_SECURITY_FIPS) {
@@ -977,10 +972,9 @@ static int l2cap_sock_setsockopt(struct socket *sock, int level, int optname, 
			break;

		}



		if (copy_from_sockptr(&opt, optval, sizeof(u32))) {

			err = -EFAULT;

		err = bt_copy_from_sockptr(&opt, sizeof(opt), optval, optlen);

		if (err)

			break;

		}



		if (opt) {

			set_bit(BT_SK_DEFER_SETUP, &bt_sk(sk)->flags);
@@ -992,10 +986,9 @@ static int l2cap_sock_setsockopt(struct socket *sock, int level, int optname, 
		break;



	case BT_FLUSHABLE:

		if (copy_from_sockptr(&opt, optval, sizeof(u32))) {

			err = -EFAULT;

		err = bt_copy_from_sockptr(&opt, sizeof(opt), optval, optlen);

		if (err)

			break;

		}



		if (opt > BT_FLUSHABLE_ON) {

			err = -EINVAL;
@@ -1027,11 +1020,9 @@ static int l2cap_sock_setsockopt(struct socket *sock, int level, int optname, 


		pwr.force_active = BT_POWER_FORCE_ACTIVE_ON;



		len = min_t(unsigned int, sizeof(pwr), optlen);

		if (copy_from_sockptr(&pwr, optval, len)) {

			err = -EFAULT;

		err = bt_copy_from_sockptr(&pwr, sizeof(pwr), optval, optlen);

		if (err)

			break;

		}



		if (pwr.force_active)

			set_bit(FLAG_FORCE_ACTIVE, &chan->flags);
@@ -1065,10 +1056,9 @@ static int l2cap_sock_setsockopt(struct socket *sock, int level, int optname, 
		break;



	case BT_SNDMTU:

		if (!bdaddr_type_is_le(chan->src_type)) {

			err = -EINVAL;

		err = bt_copy_from_sockptr(&opt, sizeof(opt), optval, optlen);

		if (err)

			break;

		}



		/* Setting is not supported as it's the remote side that

		 * decides this.
@@ -1088,10 +1078,9 @@ static int l2cap_sock_setsockopt(struct socket *sock, int level, int optname, 
			break;

		}



		if (copy_from_sockptr(&mtu, optval, sizeof(u16))) {

			err = -EFAULT;

		err = bt_copy_from_sockptr(&mtu, sizeof(mtu), optval, optlen);

		if (err)

			break;

		}



		if (chan->mode == L2CAP_MODE_EXT_FLOWCTL &&

		    sk->sk_state == BT_CONNECTED)
@@ -1119,10 +1108,9 @@ static int l2cap_sock_setsockopt(struct socket *sock, int level, int optname, 
			break;

		}



		if (copy_from_sockptr(&mode, optval, sizeof(u8))) {

			err = -EFAULT;

		err = bt_copy_from_sockptr(&mode, sizeof(mode), optval, optlen);

		if (err)

			break;

		}



		BT_DBG("mode %u", mode);