Commit 5d5b7d50 authored by Johan Hovold's avatar Johan Hovold Committed by Vinod Koul
Browse files

phy: qcom-qmp-usb: clean up pipe clock handling 



Clean up the pipe clock handling by using dev_err_probe() to handle
probe deferral and dropping the obsolete comment that claimed that the
pipe clock was optional for some other PHY types.

Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20220623113314.29761-4-johan+linaro@kernel.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 36db6ce1

drivers/phy/qualcomm/phy-qcom-qmp-usb.c

+2 −13
Original line number Diff line number Diff line
@@ -2530,22 +2530,11 @@ int qcom_qmp_phy_usb_create(struct device *dev, struct device_node *np, int id, 
	if (!qphy->pcs_misc)

		dev_vdbg(dev, "PHY pcs_misc-reg not used\n");



	/*

	 * Get PHY's Pipe clock, if any. USB3 and PCIe are PIPE3

	 * based phys, so they essentially have pipe clock. So,

	 * we return error in case phy is USB3 or PIPE type.

	 * Otherwise, we initialize pipe clock to NULL for

	 * all phys that don't need this.

	 */

	snprintf(prop_name, sizeof(prop_name), "pipe%d", id);

	qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name);

	if (IS_ERR(qphy->pipe_clk)) {

		ret = PTR_ERR(qphy->pipe_clk);

		if (ret != -EPROBE_DEFER)

			dev_err(dev,

				"failed to get lane%d pipe_clk, %d\n",

				id, ret);

		return ret;

		return dev_err_probe(dev, PTR_ERR(qphy->pipe_clk),

				     "failed to get lane%d pipe clock\n", id);

	}



	generic_phy = devm_phy_create(dev, np, &qcom_qmp_phy_usb_ops);