Commit 5d2ae142 authored by Bart Van Assche's avatar Bart Van Assche Committed by Jens Axboe
Browse files

block: Fix the bio.bi_opf comment 



Commit ef295ecf modified the Linux kernel such that the bottom bits
of the bi_opf member contain the operation instead of the topmost bits.
That commit did not update the comment next to bi_opf. Hence this patch.

From commit ef295ecf:
-#define bio_op(bio)    ((bio)->bi_opf >> BIO_OP_SHIFT)
+#define bio_op(bio)    ((bio)->bi_opf & REQ_OP_MASK)

Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Fixes: ef295ecf ("block: better op and flags encoding")
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20220511235152.1082246-1-bvanassche@acm.org


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 5ce7729f

include/linux/blk_types.h

+2 −3
Original line number Diff line number Diff line
@@ -246,9 +246,8 @@ typedef unsigned int blk_qc_t; 
struct bio {

	struct bio		*bi_next;	/* request queue link */

	struct block_device	*bi_bdev;

	unsigned int		bi_opf;		/* bottom bits req flags,

						 * top bits REQ_OP. Use

						 * accessors.

	unsigned int		bi_opf;		/* bottom bits REQ_OP, top bits

						 * req_flags.

						 */

	unsigned short		bi_flags;	/* BIO_* below */

	unsigned short		bi_ioprio;