Commit 5d280268 authored by akshatzen's avatar akshatzen Committed by Martin K. Petersen
Browse files

scsi: pm80xx: Fix missing tag_free in NVMD DATA req 

Tag was not freed in NVMD get/set data request failure scenario. This
caused a tag leak each time a request failed.

Link: https://lore.kernel.org/r/20210109123849.17098-5-Viswas.G@microchip.com


Acked-by: default avatarJack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: default avatarakshatzen <akshatzen@google.com>
Signed-off-by: default avatarViswas G <Viswas.G@microchip.com>
Signed-off-by: default avatarRuksar Devadi <Ruksar.devadi@microchip.com>
Signed-off-by: default avatarRadha Ramachandran <radha@google.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 95652f98

drivers/scsi/pm8001/pm8001_hwi.c

+10 −4
Original line number Diff line number Diff line
@@ -3038,8 +3038,8 @@ void pm8001_mpi_set_nvmd_resp(struct pm8001_hba_info *pm8001_ha, void *piomb) 
	complete(pm8001_ha->nvmd_completion);

	pm8001_dbg(pm8001_ha, MSG, "Set nvm data complete!\n");

	if ((dlen_status & NVMD_STAT) != 0) {

		pm8001_dbg(pm8001_ha, FAIL, "Set nvm data error!\n");

		return;

		pm8001_dbg(pm8001_ha, FAIL, "Set nvm data error %x\n",

				dlen_status);

	}

	ccb->task = NULL;

	ccb->ccb_tag = 0xFFFFFFFF;
@@ -3062,11 +3062,17 @@ pm8001_mpi_get_nvmd_resp(struct pm8001_hba_info *pm8001_ha, void *piomb) 


	pm8001_dbg(pm8001_ha, MSG, "Get nvm data complete!\n");

	if ((dlen_status & NVMD_STAT) != 0) {

		pm8001_dbg(pm8001_ha, FAIL, "Get nvm data error!\n");

		pm8001_dbg(pm8001_ha, FAIL, "Get nvm data error %x\n",

				dlen_status);

		complete(pm8001_ha->nvmd_completion);

		/* We should free tag during failure also, the tag is not being

		 * freed by requesting path anywhere.

		 */

		ccb->task = NULL;

		ccb->ccb_tag = 0xFFFFFFFF;

		pm8001_tag_free(pm8001_ha, tag);

		return;

	}



	if (ir_tds_bn_dps_das_nvm & IPMode) {

		/* indirect mode - IR bit set */

		pm8001_dbg(pm8001_ha, MSG, "Get NVMD success, IR=1\n");