Commit 5cff6eec authored by Ahmad Fatoum's avatar Ahmad Fatoum Committed by Wentao Guan
Browse files

gpio: mxc: remove dead code after switch to DT-only 

stable inclusion
from stable-v6.6.76
commit d5a17441bb38ca558fae0a80664cb7b1222787bf
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IBW08Q

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=d5a17441bb38ca558fae0a80664cb7b1222787bf



--------------------------------

[ Upstream commit b049e7abe9001a780d58e78e3833dcceee22f396 ]

struct platform_device::id was only set by board code, but since i.MX
became a devicetree-only platform, this will always be -1
(PLATFORM_DEVID_NONE).

Note: of_alias_get_id() returns a negative number on error and base
treats all negative errors the same, so we need not add any additional
error handling.

Fixes: 0f2c7af4 ("gpio: mxc: Convert the driver to DT-only")
Signed-off-by: default avatarAhmad Fatoum <a.fatoum@pengutronix.de>
Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/r/20250113-b4-imx-gpio-base-warning-v1-3-0a28731a5cf6@pengutronix.de


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
(cherry picked from commit d5a17441bb38ca558fae0a80664cb7b1222787bf)
Signed-off-by: default avatarWentao Guan <guanwentao@uniontech.com>
parent 469a3b79

drivers/gpio/gpio-mxc.c

+1 −2
Original line number Diff line number Diff line
@@ -490,8 +490,7 @@ static int mxc_gpio_probe(struct platform_device *pdev) 
	port->gc.request = mxc_gpio_request;

	port->gc.free = mxc_gpio_free;

	port->gc.to_irq = mxc_gpio_to_irq;

	port->gc.base = (pdev->id < 0) ? of_alias_get_id(np, "gpio") * 32 :

					     pdev->id * 32;

	port->gc.base = of_alias_get_id(np, "gpio") * 32;



	err = devm_gpiochip_add_data(&pdev->dev, &port->gc, port);

	if (err)